Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Collator' expression for controlling case and diacritic sensitivity in string comparisons #6270

Merged
merged 3 commits into from
Apr 16, 2018
Merged

'Collator' expression for controlling case and diacritic sensitivity in string comparisons #6270

merged 3 commits into from
Apr 16, 2018

Commits on Apr 13, 2018

  1. Add 'collator' expression for locale-aware string comparison: 

    ['collator',
  <case-sensitive>,
  <diacritic-sensitive>,
  (optional) <IETF language tag>]

Add 'resolved-locale' to test if requested collation locale is available:
['resolved-locale', <collator>]

'==','!=','<','<=,'>','>=' now take an optional 'collator' argument when they are used with 'string' arguments.
    @ChrisLoer
    ChrisLoer committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    7af3d65 View commit details
    Browse the repository at this point in the history

  2. Move 'collator' from three arguments to a single "options" argument. 

    Support/test default behavior when case/diacriticSensitivity isn't specified.
    @ChrisLoer
    ChrisLoer committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    3c92fc5 View commit details
    Browse the repository at this point in the history

  3. Address Collator review comments: 

    - CollatorInstantiation -> Collator (and try to keep Intl.Collator in its own scope)
- Collator holds onto its Intl.Collator now so it can be used across multiple compares
- Add Collator to values.js
- Fix parse indexes
- Add/tidy comments
    @ChrisLoer
    ChrisLoer committed Apr 13, 2018
    Configuration menu
    Copy the full SHA
    acaf489 View commit details
    Browse the repository at this point in the history