only index features strictly within tile boundaries #6429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of indexing all features for querying, index only those that are actually within the tile boundaries. This prevents duplicate results from being returned for point features. This is only a partial fix for the duplicate results problem (lines and polygons can still return duplicate results).
ChrisLoer
approved these changes
Apr 2, 2018
There was a problem hiding this comment.
Looks good to me!
The part of the logic I tried to scrutinize the most is how this interacts with symbol features, which aren't covered by the changes in #6036. My reading is that we'll still be in the same situation described in #6298: we may miss querying some tiles altogether, but if we query a tile for symbols, it won't be affected by this change because symbol queries don't touch the non-symbol grid.
Yep, this is how I understand it as well. |
anandthakker
pushed a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Apr 5, 2018
anandthakker
added a commit
to mapbox/mapbox-gl-native
that referenced
this pull request
Apr 9, 2018
* Fix style parsing bug for constant expressions Closes #10849 * Ignore tests for unported GL JS change Refs mapbox/mapbox-gl-js#6429 * Fuller fix * Update mapbox-gl-js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of indexing all features for querying, index only those that are actually within the tile boundaries. This prevents duplicate results from being returned for point features. This is only a partial fix for the duplicate results problem (lines and polygons can still return
duplicate results).
Previously we relied on tile buffers for cross-tile indexing. But now that we have #6036 we don't need that anymore.
I noticed this while porting #6036 to -native. These test changes would be useful to have for that port.
Launch Checklist