Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include link to license in compiled bundle #6970

Merged
merged 1 commit into from
Jul 16, 2018
Merged

Conversation

anandthakker
Copy link
Contributor

No description provided.

@anandthakker
Copy link
Contributor Author

Adds the following comment as the first line to the mapbox-gl.js and mapbox-gl-dev.js compiled bundles:

/* Mapbox GL JS is licensed under the 3-Clause BSD License. Full text of license: https://github.com/mapbox/mapbox-gl-js/blob/v0.46.0/LICENSE.txt */

@anandthakker
Copy link
Contributor Author

^ currently using the package.json version field to construct the URL https://github.com/.../blob/vX.Y.Z/LICENSE.txt

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Maybe worth linking to the raw text though? https://raw.githubusercontent.com/mapbox/mapbox-gl-js/v0.46.0/LICENSE.txt

@anandthakker
Copy link
Contributor Author

I went w/ the GitHub UI link because it's a little easier to navigate to the rest of the repo (and "Raw" is still just one click away)... but I'll defer to whatever others think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants