Publish flow types #7079
Merged
Publish flow types #7079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandthakker
force-pushed
the
publish-flow
branch
from
236ff6a to
29ab46b
Compare
|
Depends on #7078 |
jfirebaugh
approved these changes
Aug 3, 2018
Closes #6963
anandthakker
force-pushed
the
publish-flow
branch
from
29ab46b to
13a1522
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6963
Downstream projects using Flow should now get typing for gl-js. However,
you'll need to include libdefs for some of our dependencies. Our libdefs are
included with the
mapbox-glNPM package, so you can get them by adding:You'll also need to add an ignore for one of our dependencies that causes
Flow errors: