Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "to-number" of null behave as documented #7274

Merged
merged 1 commit into from
Sep 12, 2018
Merged

Make "to-number" of null behave as documented #7274

merged 1 commit into from
Sep 12, 2018

Conversation

jfirebaugh
Copy link
Contributor

Fixes #7083.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • tagged @mapbox/studio and/or @mapbox/maps-design if this PR includes style spec changes

ChrisLoer
ChrisLoer approved these changes Sep 12, 2018
View reviewed changes
Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any written discussion tracking why we (at least in the documentation) chose this behavior in the first place? The documented behavior seems reasonable to me, but I could also see it going the other way.

@jfirebaugh
Copy link
Contributor Author

No, not that I'm aware of.

@jfirebaugh jfirebaugh merged commit a1dca3c into master Sep 12, 2018
@jfirebaugh jfirebaugh deleted the fix-7083 branch September 12, 2018 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfirebaugh @ChrisLoer