Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only render control-group box-shadow when the control-group has child controls #7304

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Only render control-group box-shadow when the control-group has child controls #7304

merged 1 commit into from
Sep 20, 2018

Conversation

Duder-onomy
Copy link

This adds a :not(:empty) selector to the .mapbopx-ctrl-group selectors box-shadow definition.

Fixes #7303

Browser Support for :not()
Browser Support for :empty

Launch Checklist

  • [ChYAH] briefly describe the changes in this PR
  • [NA] write tests for all new functionality
  • [NA] document any changes to public APIs
  • [MA] post benchmark scores
  • [CHYAH] manually test the debug page
  • [NA] tagged @mapbox/studio and/or @mapbox/maps-design if this PR includes style spec changes

ryanhamley
ryanhamley approved these changes Sep 20, 2018
View reviewed changes
Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks for taking care of it!

@ryanhamley ryanhamley merged commit 016d95c into mapbox:master Sep 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhamley ryanhamley ryanhamley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Duder-onomy @ryanhamley