Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log expressions in IE #7320

Merged
merged 1 commit into from
Sep 22, 2018
Merged

Fix log expressions in IE #7320

merged 1 commit into from
Sep 22, 2018

Conversation

mourner
Copy link
Member

@mourner mourner commented Sep 21, 2018

Closes #7318 — IE11 doesn't support Math.log2 and Math.log10.

@mourner mourner requested a review from ryanhamley September 21, 2018 15:59
@mourner mourner mentioned this pull request Sep 21, 2018
Closed
mollymerp
mollymerp approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty!

ryanhamley
ryanhamley approved these changes Sep 21, 2018
View reviewed changes
Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@mourner mourner merged commit 23ac915 into master Sep 22, 2018
@mourner mourner deleted the ie-log-fix branch September 22, 2018 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanhamley ryanhamley ryanhamley approved these changes

@mollymerp mollymerp mollymerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mourner @mollymerp @ryanhamley