Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show attribution only for used sources, fix #6281 #7384

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Oct 9, 2018

fixes #6281

Sources are sometimes used by no layers or are used only by layers that are disabled with visibility: 'none'. This hides attribution for these sources. This makes the attribution more relevant for cases where the map contains many layers are toggled on and off.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page

@ansis ansis requested a review from mourner October 9, 2018 04:21
@ansis ansis merged commit 650635f into master Oct 9, 2018
@ansis ansis deleted the attribution-visibility branch October 9, 2018 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribution shows even when layer not visible
2 participants