Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show IE11 compact attribution #7391

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Show IE11 compact attribution #7391

merged 1 commit into from
Oct 9, 2018

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

Fixes #3945

screen shot 2018-10-09 at 2 40 20 pm

  • briefly describe the changes in this PR
    • IE11 has a rendering bug that was preventing the compact attribution from displaying which could present legal issues for customers
  • manually test the debug page
    • Tested manually on Chrome, Safari, Firefox, Edge and IE11

@ryanhamley ryanhamley requested a review from mollymerp October 9, 2018 21:57
mollymerp
mollymerp approved these changes Oct 9, 2018
View reviewed changes
Copy link
Contributor

@mollymerp mollymerp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨thank you!

one question – can we remove visibility from the ::after pseudo class styles now?

@ryanhamley
Copy link
Contributor Author

Yep, I removed visibility from the psuedo class.

@ryanhamley ryanhamley merged commit 544d377 into master Oct 9, 2018
@ryanhamley ryanhamley deleted the ie-attribution branch October 9, 2018 23:18
@kkaefer kkaefer mentioned this pull request Oct 10, 2018
Merged
2 tasks
@ryanhamley ryanhamley mentioned this pull request Oct 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mollymerp mollymerp mollymerp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanhamley @mollymerp