Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #7410: using hash within iframes in IE11 #7411

Merged
merged 1 commit into from
Oct 12, 2018
Merged

fix #7410: using hash within iframes in IE11 #7411

merged 1 commit into from
Oct 12, 2018

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Oct 12, 2018

fix #7410

If you create a map with the option "hash": true within an iframe, written with iframe.contentWindow.document.write(...) and open it in IE, then the hash control's attempt to replace the history state triggers a SecurityError and breaks the page.

I'm not sure how we could test this.

@kkaefer we could add this to the release but I'm also not seeing much harm from leaving it for the next release.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality

@ansis ansis requested a review from kkaefer October 12, 2018 02:17
@ansis ansis force-pushed the fix-hash-within-iframe-ie branch from 9712177 to 7febf0c Compare October 12, 2018 02:20
@ansis ansis merged commit d9a45c4 into master Oct 12, 2018
@kkaefer kkaefer deleted the fix-hash-within-iframe-ie branch October 12, 2018 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkaefer kkaefer kkaefer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

using "hash": true triggers error within iframe in IE
2 participants
@ansis @kkaefer