fix compact attribution positioning #7445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
approved these changes
Oct 19, 2018
|
🤦♀️sorry I meant I would be in favor of making them all consistently 5px (edited OP to fix) This is what it looks like: |
mollymerp
force-pushed
the
attribution-position
branch
from
9ec5deb to
3f2c6c1
Compare
|
I'm always in favor of symmetry. I think 5px is fine. |
|
turns out 10px looks better with other controls, so I'm going with that for all positions. |
mollymerp
force-pushed
the
attribution-position
branch
from
61559d8 to
18603e3
Compare
|
I ended up switching back to 10px margin because it ends up looking better when using other controls on the map. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #7439
note: the 10px margin that the
bottom-rightcompact control has looks odd when applied to the other control locations, so I reduced it to 5px. I would be in favor of making them all consistent at 5px – thoughts?Launch Checklist