Fix for issue 7438 by improving getRoundNum() function. #7469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onding unit test and debug page.
mourner
reviewed
Oct 23, 2018
src/ui/control/scale_control.js
Outdated
| d >= 0.001 ? Math.round(d * 1000) / 1000 : | ||
| d >= 0.0001 ? Math.round(d * 10000) / 10000 : | ||
| d >= 0.00001 ? Math.round(d * 100000) / 100000 : Math.round(d * 1000000) / 1000000; | ||
| // Could go on forever of course, depending on the unit used. But this is good enough for 'imperial', 'metric' and 'nautical'. |
There was a problem hiding this comment.
This can probably be generalized — looks like you can calculate the multiplier with Math.pow(10, Math.ceil(-Math.log(d) / Math.LN10)).
There was a problem hiding this comment.
Yes, I thought of that, but couldn't come up with the right formula. I'll try adding your formula.
There was a problem hiding this comment.
Done. Please check latest commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #7438 by improving getRoundNum() function. Added corresponding unit test and debug page.