Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove controls before destroying map #7479

Merged
merged 1 commit into from
Oct 26, 2018
Merged

remove controls before destroying map #7479

merged 1 commit into from
Oct 26, 2018

Conversation

ansis
Copy link
Contributor

@ansis ansis commented Oct 24, 2018

This removes the controls before destroying the map so that:

  • the map is in a valid state when onRemove is called for each control
  • so that the frame can be cancelled after removal in case onRemove triggers a render frame

fix #7478

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page

@ansis ansis requested review from mollymerp and ryanhamley October 24, 2018 23:32
Copy link
Contributor

@ryanhamley ryanhamley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Seems like calling onRemove after the map was destroyed should always have been considered buggy behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

error when accessing style in a control's onRemove
2 participants