Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo url to correct one #7486

Merged
merged 1 commit into from
Oct 31, 2018
Merged

Update repo url to correct one #7486

merged 1 commit into from
Oct 31, 2018

Conversation

nicholas-l
Copy link
Contributor

@nicholas-l nicholas-l commented Oct 25, 2018

The url points to the old outdated repo and I am hoping that yarn uses this for the URL column when running yarn outdated :)

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • document any changes to public APIs
  • post benchmark scores
  • manually test the debug page
  • tagged @mapbox/studio and/or @mapbox/maps-design if this PR includes style spec changes

The url points to the old outdated repo
@ChrisLoer ChrisLoer requested a review from mourner October 25, 2018 21:44
@mourner
Copy link
Member

mourner commented Oct 25, 2018

Should we change that to point to the specific folder? At least that's what Babel uses: https://github.com/babel/babel/blob/master/packages/babel-highlight/package.json#L11
(Although on the other hand, e.g. React packages point to the same facebook/react repo, so no defined standard here)

@nicholas-l
Copy link
Contributor Author

I would leave it as the repository not the folder as if the packages gets moved or the main branch changes, the url may not get updated, leaving a bad user experience (404 page).

@mourner mourner merged commit cf7d2f8 into mapbox:master Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants