fixed issue "Marker element click event throws: Uncaught TypeError..." #8049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixed if marker click is triggered programatically, throw the exception. mapbox#7864
|
@ParryQiu You should follow the code convention, fix your code and try to build on your local environment. |
ParryQiu
changed the title
mourner
requested changes
Mar 18, 2019
There was a problem hiding this comment.
Unfortunately Event.isTrusted is not supported in Safari (both desktop and mobile) and IE11. We'll have to come up with a fix that works cross-platform.
|
You might also want a simple check for if startPos is defined, if not then just treat as a click and skip the proximity check. |
|
Closing in favor of #8462. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed if marker click is triggered programatically, throw the exception.
#7864