Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add render test for format expression nested under decision expression #8093

Merged
merged 1 commit into from
Mar 28, 2019

Conversation

alexshalamov
Copy link
Contributor

Render test for mapbox/mapbox-gl-native#14254
GL native fix: mapbox/mapbox-gl-native#14259

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality

Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are separate tests needed for nested format expressions with text-scale and text-font as well?

@alexshalamov
Copy link
Contributor Author

Are separate tests needed for nested format expressions with text-scale and text-font as well?

I don't think so, I quickly made few tests with font-scale and text-font options and these are not exercising code that I'm adding in #8068, Chris made quite a good test suite for layout specific properties. If I find that something is missing, I would definitely add more unit / render tests.

@alexshalamov alexshalamov merged commit 840846f into master Mar 28, 2019
@alexshalamov alexshalamov deleted the alexshalamov_add_nested_expr_rendertest branch March 28, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants