Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add render test for symbol-sort-key with ignored icon / text placement #8198

Merged
merged 1 commit into from
Jul 3, 2019
Merged

Add render test for symbol-sort-key with ignored icon / text placement #8198

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/ignores.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,5 +21,6 @@
"render-tests/text-field/formatted-text-color": "skip - https://github.com/mapbox/mapbox-gl-js/issues/8045",
"render-tests/runtime-styling/layout-property-override-paint-property-expression": "skip - https://github.com/mapbox/mapbox-gl-js/issues/8045",
"render-tests/runtime-styling/layout-property-override-paint-property-literal": "skip - https://github.com/mapbox/mapbox-gl-js/issues/8045",
"render-tests/text-field/formatted-text-color-overrides-nested-expression": "skip - https://github.com/mapbox/mapbox-gl-js/issues/8045"
"render-tests/text-field/formatted-text-color-overrides-nested-expression": "skip - https://github.com/mapbox/mapbox-gl-js/issues/8045",
"render-tests/symbol-sort-key/text-ignore-placement": "skip - text drawn over icons"
}
Binary file added test/integration/render-tests/symbol-sort-key/text-ignore-placement/expected.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
107 changes: 107 additions & 0 deletions test/integration/render-tests/symbol-sort-key/text-ignore-placement/style.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,107 @@
{
"version": 8,
"metadata": {
"test": {
"height": 64,
"width": 64
}
},
"center": [0, 32],
"zoom": 1,
"sources": {
"geojson": {
"type": "geojson",
"data": {
"type": "FeatureCollection",
"features": [
{
"type": "Feature",
"properties": {
"color": "red",
"sort-key": 1,
"image": "interstate_2"
},
"geometry": {
"type": "Point",
"coordinates": [
6,
35
]
}
},
{
"type": "Feature",
"properties": {
"color": "green",
"sort-key": 0,
"image": "interstate_2"
},
"geometry": {
"type": "Point",
"coordinates": [
6,
29
]
}
}, {
"type": "Feature",
"properties": {
"color": "red",
"sort-key": 1,
"image": "interstate_2"
},
"geometry": {
"type": "Point",
"coordinates": [
-6,
35
]
}
},
{
"type": "Feature",
"properties": {
"color": "green",
"sort-key": 0,
"image": "interstate_2"
},
"geometry": {
"type": "Point",
"coordinates": [
-6,
29
]
}
}
]
}
}
},
"sprite": "local://sprites/emerald",
"glyphs": "local://glyphs/{fontstack}/{range}.pbf",
"layers": [
{
"id": "icon",
"type": "symbol",
"source": "geojson",
"layout": {
"symbol-sort-key": ["get", "sort-key"],
"icon-image": ["get", "image"],
"icon-allow-overlap": true,
"icon-ignore-placement": true,
"text-allow-overlap": true,
"text-ignore-placement": true,
"text-field": ["get", "sort-key"],
"text-font": [
"Open Sans Semibold",
"Arial Unicode MS Bold"
]
},
"paint": {
"text-color": "rgb(255,255,255)",
"text-halo-width": 1,
"text-halo-color": ["get", "color"]
}
}
]
}