-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional visualizePitch option for NavigationControl and add touch support for pitching with compass icon #8296
Conversation
Again, you can try out the feature here: https://aviamaps.com/map |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to fix the remaining lint and flow errors.
Oh sorry, I’ve never used Flow. I’ll study how to run it. |
All tests passing now and working perfectly: https://aviamaps.com/map |
Oh ok, you seem to already changed that 👍 |
Ready to merge? 😎 |
I took a quick review and I can't see any issues, testing it out seemed to work very well. In the future when #3731 lands I think we'll want to add a limit to how much the icon will pitch. |
Ok, so ready to merge? 🙂 |
I'll leave it to Mapbox to make that call, but as far as my testing went, it looks good. |
@pakastin thank you for your patience! This will get into v1.2.0 later this month. |
Ok great! Just waiting to get rid of the custom build hassle. 👍 |
Reverting #8226, the revert of #8281 😄
Fixes #8208. Related: #3405