Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional visualizePitch option for NavigationControl and add touch support for pitching with compass icon #8296

Merged
merged 9 commits into from
Jul 2, 2019

Conversation

pakastin
Copy link
Contributor

@pakastin pakastin commented May 29, 2019

Reverting #8226, the revert of #8281 😄

Fixes #8208. Related: #3405

@pakastin
Copy link
Contributor Author

Again, you can try out the feature here: https://aviamaps.com/map

Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to fix the remaining lint and flow errors.

@pakastin
Copy link
Contributor Author

Oh sorry, I’ve never used Flow. I’ll study how to run it.

@pakastin
Copy link
Contributor Author

All tests passing now and working perfectly: https://aviamaps.com/map

@mourner
Copy link
Member

mourner commented May 31, 2019

@pakastin this PR shouldn't close #3405 because that one is about mobile gesture on the map (two-finger pan to pitch like in native map apps), and this PR only targets the compass icon.

@pakastin
Copy link
Contributor Author

Oh ok, you seem to already changed that 👍

@pakastin
Copy link
Contributor Author

pakastin commented Jun 3, 2019

Ready to merge? 😎

@andrewharvey
Copy link
Collaborator

I took a quick review and I can't see any issues, testing it out seemed to work very well.

In the future when #3731 lands I think we'll want to add a limit to how much the icon will pitch.

@pakastin
Copy link
Contributor Author

pakastin commented Jul 2, 2019

Ok, so ready to merge? 🙂

@andrewharvey
Copy link
Collaborator

Ok, so ready to merge? slightly_smiling_face

I'll leave it to Mapbox to make that call, but as far as my testing went, it looks good.

@mourner mourner merged commit c8a2627 into mapbox:master Jul 2, 2019
@mourner
Copy link
Member

mourner commented Jul 2, 2019

@pakastin thank you for your patience! This will get into v1.2.0 later this month.

@pakastin
Copy link
Contributor Author

pakastin commented Jul 2, 2019

Ok great! Just waiting to get rid of the custom build hassle. 👍
Aviamaps now has custom build with v1.1.0 + this update working: https://aviamaps.com/map

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tilting compass as map tilted
3 participants