Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make requirements for text offset props more precise #8418

Merged
merged 2 commits into from
Jul 5, 2019
Merged

Make requirements for text offset props more precise #8418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cacc6d5
Make requirements for text offset props more precise
Jul 1, 2019
ac5aa4d
Overriding text properties have fewer requirements
Jul 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 9 additions & 13 deletions src/style-spec/reference/v8.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1815,9 +1815,7 @@
}
},
"requires": [
{
"!" : "text-offset"
}
"text-field"
],
"property-type": "data-driven",
"expression": {
Expand Down Expand Up @@ -1861,12 +1859,7 @@
}
},
"requires": [
{
"!": "text-anchor"
},
{
"!": "text-offset"
},
"text-field",
{
"symbol-placement": [
"point"
Expand Down Expand Up @@ -1898,9 +1891,6 @@
},
"text-anchor": {
"type": "enum",
"requires": {
"!": "text-variable-anchor"
},
"values": {
"center": {
"doc": "The center of the text is placed closest to the anchor."
Expand Down Expand Up @@ -1933,7 +1923,10 @@
"default": "center",
"doc": "Part of the text placed closest to the anchor.",
"requires": [
"text-field"
"text-field",
{
"!": "text-variable-anchor"
}
],
"sdk-support": {
"basic functionality": {
Expand Down Expand Up @@ -2135,6 +2128,9 @@
"text-field",
{
"!": "text-radial-offset"
},
{
"!": "text-variable-anchor"
}
],
"sdk-support": {
Expand Down