Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable combinations/fill-extrusion-translucent--background-opaque #8440

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

astojilj
Copy link
Contributor

@astojilj astojilj commented Jul 7, 2019

and combinations/fill-extrusion-translucent--fill-opaque tests.

combinations/fill-extrusion-translucent--fill-opaque was already passing, but ignored.
Copied the approach from fill-opaque rendering to background.

Related to #5831

and combinations/fill-extrusion-translucent--fill-opaque tests.

Related to #5831
@astojilj astojilj requested review from ansis and mourner July 7, 2019 21:30
@astojilj astojilj self-assigned this Jul 7, 2019
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but I'd wait for @ansis's comment to make sure we don't miss anything.

Copy link
Contributor

@ansis ansis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks

@astojilj astojilj merged commit 86ac0dd into master Jul 9, 2019
@mourner mourner deleted the astojilj-5831 branch August 1, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants