Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor normalize and canonicalize URL methods #8456

Merged
merged 2 commits into from
Jul 11, 2019
Merged

Refactor normalize and canonicalize URL methods #8456

merged 2 commits into from
Jul 11, 2019

Conversation

ryanhamley
Copy link
Contributor

Launch Checklist

closes #8453

  • briefly describe the changes in this PR
    • refactors normalize...URL and canonicalize... methods into the RequestManager class

@ryanhamley ryanhamley force-pushed the refactor-request-manager branch from c957565 to 76dea41 Compare July 10, 2019 22:43
mourner
mourner approved these changes Jul 11, 2019
View reviewed changes
Copy link
Member

@mourner mourner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much clearer now!

@ryanhamley ryanhamley merged commit be7e27f into master Jul 11, 2019
@ryanhamley ryanhamley deleted the refactor-request-manager branch July 11, 2019 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mourner mourner mourner approved these changes

@peterqliu peterqliu Awaiting requested review from peterqliu

@asheemmamoowala asheemmamoowala Awaiting requested review from asheemmamoowala

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor RequestManager normalize...URL and canonicalize... methods
2 participants
@ryanhamley @mourner