[style-spec] expose convertFilter API #8493
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the
convertFilter
atmapbox-gl-js/src/style-spec/feature_filter/convert.js
Line 14 in b5c9020
I need this exposed to be able to auto-upgrade legacy filters in a downstream module that uses
require('@mapbox/mapbox-gl-style-spec')
(mapbox/vtshaver#30)The larger context is that I need to combine multiple filters into one array to pass them to gl-native. However gl-native cannot cope with mixing legacy filters (see https://docs.mapbox.com/mapbox-gl-js/style-spec/other/) and new style expressions. Previously it crashed and now it throws (mapbox/mapbox-gl-native#12065). But ideally, through auto-upgrading using this newly exposed function, I can avoid gl-native throwing.
Thanks @samanpwbb and
@mapbox/studio
for recommending this fix.