Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resource loading edge cases #8612

Merged
merged 4 commits into from
Aug 15, 2019
Merged

Fix resource loading edge cases #8612

merged 4 commits into from
Aug 15, 2019

Conversation

kkaefer
Copy link
Member

@kkaefer kkaefer commented Aug 9, 2019

This PR bundles a few fixes for edge cases in resource loading:

  • Changes URLs in our debug pages to be relative, so that we can test them when loaded via the file:// URL scheme as well (as long as they don't depend on other local resources)
  • Fixes a bug that broke map loading when the document containing the map view was loaded from a blob URL: Referrer error in iframe #8069
  • Classifies relative URLs as file:// URLs when the original document was loaded from a file URL to avoid using Fetch for those.

@kkaefer
Copy link
Member Author

kkaefer commented Aug 9, 2019

Things to test:

  • Are we sending correct referrers in all browsers?
  • Does the new debug/iframe-blob.html page work in all browsers?
  • Does the debug/index.html page work when loaded via a file:// URL?

Copy link
Contributor

@asheemmamoowala asheemmamoowala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the new debug/iframe-blob.html page work in all browsers?

Verified on OSX Safari/Chrome/Firefox, Android Chrome/Firefox, and Windows Edge.
Did not seem to work on IE11 😢

Does the debug/index.html page work when loaded via a file:// URL?

debug/access_token.js Outdated Show resolved Hide resolved
@kkaefer
Copy link
Member Author

kkaefer commented Aug 15, 2019

IE doesn't support HTML documents loaded from data or blob URLs.

@kkaefer
Copy link
Member Author

kkaefer commented Aug 15, 2019

Changelog entry:

  • Fix map loading for documents loaded from Blob URLs
  • Improve classification of relative URLs as file:// URLs when the document was loaded from a file URL

@kkaefer kkaefer merged commit 9a3934c into master Aug 15, 2019
@kkaefer kkaefer deleted the fetch-fixes branch August 15, 2019 08:50
@ryanhamley ryanhamley mentioned this pull request Aug 16, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants