-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Address user feedback on resize and *RenderedWorldCopies #8748
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
92f6fe2
make it clear that ui handlers examples are below
colleenmcginnis 4e36e09
add examples related to controls
colleenmcginnis 5ac06c5
add examples related to bounds
colleenmcginnis 9878a47
add examples related to min and max zoom levels
colleenmcginnis 5380795
clarify what renderWorldCopies means, adds related examples
colleenmcginnis 872dd20
add examples related to project and unproject, remove old related link
colleenmcginnis db30dac
examples for isMoving, isZooming, isRotating
colleenmcginnis 9ae1ea7
clean up query*Features
colleenmcginnis 2f0ea1e
add more deailts to resize, add example
colleenmcginnis 0a85632
clean up copy
colleenmcginnis 85207c6
address feedback from @mourner and @andrewharvey
colleenmcginnis 7dab413
fix linting errors
colleenmcginnis 947178d
apply @mourner's suggestions from code review
f625b5a
add new language to getRenderWorldCopies and setRenderWorldCopies
39f0956
add link to render-world-copies example
colleenmcginnis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe worth clarifying all the handler comments with what you can actually do with the property? E.g. "Allows you to control scroll zooming behavior dynamically (toggle on and off, adjust options, etc.)".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I started doing this, but it felt repetitive. What do you think about skipping this for now and reevaluating if we continue to get feedback on these sections?