[docs] Address user feedback for /api: sources, images, layers #8754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colleenmcginnis
commented
Sep 14, 2019
mourner
approved these changes
Sep 16, 2019
| @@ -1144,9 +1144,29 @@ class Map extends Camera { | |||
| * {@link CanvasSourceOptions}. | |||
| * @fires source.add | |||
| * @returns {Map} `this` | |||
| * @see [Draw GeoJSON points](https://www.mapbox.com/mapbox-gl-js/example/geojson-markers/) | |||
| * @see [Style circles using data-driven styling](https://www.mapbox.com/mapbox-gl-js/example/data-driven-circle-colors/) | |||
| * @see [Set a point after Geocoder result](https://www.mapbox.com/mapbox-gl-js/example/point-from-geocoder-result/) | |||
There was a problem hiding this comment.
ha, I just discovered this independently, was about to submit my PR when I noticed this.
Since 6e6a005#diff-44befe964c5c5c476298e33cc55ce3e7 the geocoder example no longer uses addSource.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is one in a series that will address user feedback on the contents of the API docs including adding inline examples to all sections of the API docs and auditing
Relatedlinks for relevance.As always, all feedback is welcome! But, there are some specific things that need a close look:
addImagecorrectly?@seeresources (for example,* @see Vector source: [Show and hide layers](https://docs.mapbox.com/mapbox-gl-js/example/toggle-layers/))?setLayerZoomRangedescription.cc @mapbox/docs