Relax check for webworker transferability #8868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some browser versions, objects can be transfered even though they don't pass the check for `instanceof ArrayBuffer`. We're going to use a more forgiving check that follows a duck-typing approach.
kkaefer
force-pushed
the
arraybuffer-instanceof
branch
from
dc1e898 to
068b9de
Compare
mourner
approved these changes
Oct 14, 2019
asheemmamoowala
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some browser versions, objects can be transfered even though they don't pass the check for
instanceof ArrayBuffer. We're going to use a more forgiving check that follows a duck-typing approach.Fixes #8861 and #8287. Tested with the cypress example provided in that issue and the map now displays correctly.