Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #9676, fire touchmove event while handlers are active #9685

Merged
merged 1 commit into from
May 13, 2020

Conversation

ansis
Copy link
Contributor

@ansis ansis commented May 13, 2020

In 1.9.1 mousemove do not fire during drags. 1.10.0 preserved that behavior but mistakenly extended it to touchmove. touchmove was still fired druing drags in 1.9.1.

This fixes that regression by firing touchmove even while other handlers are active. I also added a regression unit test.

Launch Checklist

  • briefly describe the changes in this PR
  • write tests for all new functionality
  • manually test the debug page
  • apply changelog label ('bug', 'feature', 'docs', etc) or use the label 'skip changelog'
  • add an entry inside this element for inclusion in the mapbox-gl-js changelog: <changelog>Fix regression that prevented touchmove events from firing during gestures.</changelog>

@ansis ansis added the bug 🐞 label May 13, 2020
@ansis ansis requested a review from karimnaaji May 13, 2020 16:40
@karimnaaji karimnaaji mentioned this pull request May 13, 2020
7 tasks
Copy link
Contributor

@karimnaaji karimnaaji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good to match previous behaviors.

To eventually capture as follow up: should we consider firing mousemove if we do fire touchmove for consistency between the two? It might be misleading to have one fired but not the other as they could be considered a fairly matching event between mobile/desktop, at least from my understanding.

@karimnaaji karimnaaji merged commit 184b75d into master May 13, 2020
@karimnaaji karimnaaji deleted the fix-touchmove-9676 branch May 13, 2020 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants