Review nits: set an interim paint in style_layer #9688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karimnaaji
force-pushed
the
karim/undefined_paint
branch
from
0be0225 to
d8e3fe5
Compare
asheemmamoowala
approved these changes
May 14, 2020
karimnaaji
added a commit
that referenced
this pull request
May 14, 2020
* set an interim paint in style_layer * add a simple test for undefined paint * Address review nits * Silence inconsistent flow error Co-authored-by: Nick Mann <nick_j_mann@uk.ibm.com>
karimnaaji
added a commit
that referenced
this pull request
May 14, 2020
* set an interim paint in style_layer * add a simple test for undefined paint * Address review nits * Silence inconsistent flow error Co-authored-by: Nick Mann <nick_j_mann@uk.ibm.com>
harto
pushed a commit
to remix/mapbox-gl-js
that referenced
this pull request
Apr 13, 2021
* set an interim paint in style_layer * add a simple test for undefined paint * Address review nits * Silence inconsistent flow error Co-authored-by: Nick Mann <nick_j_mann@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9658 + review nits.