Prevent bearing snap ease interfering with new ease #9884
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #9793
In short,
easeTo
orflyTo
may interrupt handler driven motion when the map's bearing is within thebearingSnap
range. This triggers a bearing snapeaseTo
at the same time as the desiredeaseTo/flyTo
. The camera can't handle both of these and it freezes and errors.Further explanation of the chain of events that cause this bug is here #9793 (comment)
This PR:
allowEndAnimation
toHandlerManager#stop
to prevent a bearing snap interfering with a neweaseTo
orflyTo
._bearingChanged
ofHandlerManager
.Launch Checklist
mapbox-gl-js
changelog:<changelog>Fixed a bug where bearing snap animations interfere with new easeTo and flyTo animations and freeze the map</changelog>