Fix using within expression filter when query features
#9933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mourner
requested changes
Aug 31, 2020
There was a problem hiding this comment.
The fix itself looks good, but I'm worries that the same pattern of code is repeated multiple times — not only the two nearly identical bits here, but also similar filter code in each layer bucket file. Can we introduce some kind of utility function (maybe similar to loadGeometry) to clean this up?
zmiao
force-pushed
the
zmiao-fix-within-queryFeature
branch
from
30b73d9 to
4c3fb90
Compare
zmiao
force-pushed
the
zmiao-fix-within-queryFeature
branch
from
4c3fb90 to
9136a4c
Compare
|
@mourner sorry for the late update, now I added a new utility function for the feature construction. |
mourner
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Launch Checklist
Fix: #9923
Pass geometry and canonical tile id in when evaluating feature via
withinfiltermapbox-gl-jschangelog:<changelog>Fix using within expression filter when query features</changelog>