Fix pulse circle opacity calculate error (#625)

mapbox · Nov 19, 2020 · a470e39 · a470e39
1 parent c897a08
commit a470e39
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationLayerController.java b/MapboxGLAndroidSDK/src/main/java/com/mapbox/mapboxsdk/location/LocationLayerController.java
@@ -303,8 +303,8 @@ public void onNewAnimationValue(Float value) {
       @Override
       public void onNewAnimationValue(Float newPulseRadiusValue) {
         Float newPulseOpacityValue = null;
-        if (options.pulseFadeEnabled()) {
-          newPulseOpacityValue = (float) 1 - ((newPulseRadiusValue / 100) * 3);
+        if (options.pulseFadeEnabled() && options.pulseMaxRadius() > 0) {
+          newPulseOpacityValue = 1.0f - newPulseRadiusValue / options.pulseMaxRadius();
         }
         locationLayerRenderer.updatePulsingUi(newPulseRadiusValue, newPulseOpacityValue);
       }

diff --git a/MapboxGLAndroidSDKTestApp/src/main/AndroidManifest.xml b/MapboxGLAndroidSDKTestApp/src/main/AndroidManifest.xml
@@ -1017,6 +1017,7 @@
         </activity>
         <activity
             android:name=".activity.location.BasicLocationPulsingCircleActivity"
+            android:exported="true"
             android:description="@string/description_location_basic_pulsing_circle"
             android:label="@string/activity_basic_location_pulsing_circle">
             <meta-data
@@ -1028,6 +1029,7 @@
         </activity>
         <activity
             android:name=".activity.location.CustomizedLocationPulsingCircleActivity"
+            android:exported="true"
             android:description="@string/description_location_customized_pulsing_circle"
             android:label="@string/activity_customized_location_pulsing_circle">
             <meta-data