This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Expose option to pass intermediate points for smooth location animation #166
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
LocationComponent#forceLocation
overload, which allows passing a list of locations. The last location in the list is the desired target, while everything else makes up for the intermediate points in the otherwise linear location puck animation. This allows for better road geometry tracking and avoids "cutting" corners when 2 raw updates are on the opposite side of an intersection maneuver.This also exposes a
lookAheadUpdate
flag in the same method. If we have an ability to predict location updates, setting this flag totrue
will take the timestamp of the target location (last in the list) and calculate the animation duration equal toThis allows minimizing the visual lag that a smooth animation would introduce otherwise.
/cc @SiarheiFedartsou @mskurydin