This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Rollback to System.loadLibrary to load native library. #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, this is a nice idea! I was originally thinking that we'd need to do some profiling around Soloader vs the system library, but I think the way this is implemented, it would be safe to cherrypick into cc @mapbox/maps-android |
tobrun
reviewed
May 7, 2020
| + "call Mapbox.getInstance(Context context, String accessToken) first"); | ||
| throw new UnsatisfiedLinkError(exception.getMessage()); | ||
| //Rollback to System.loadLibrary if SoLoader failed to load library. | ||
| System.loadLibrary(name); |
There was a problem hiding this comment.
This code block won't be hit when SoLoader fails to load (we would hit a UnsatisfiedLinkError not a MapboxConfgurationException)
Chaoba
changed the title
tobrun
approved these changes
May 7, 2020
Chaoba
pushed a commit
that referenced
this pull request
May 7, 2020
* Rollback to System.loadLibrary if SoLoader failed to load library. * Remove soloader. (cherry picked from commit 01f1b1e)
Chaoba
pushed a commit
that referenced
this pull request
May 7, 2020
* Bump telemetry to 5.0.1, core to 2.0.1 (#370) (cherry picked from commit 9d5b1f6) * Rollback to System.loadLibrary to load native library. (#368) * Rollback to System.loadLibrary if SoLoader failed to load library. * Remove soloader. (cherry picked from commit 01f1b1e) * Update changelog for 9.2.0 (#371) * Update changelog for 9.2.0 * Update changelog for 9.2.0 * Update changelog for 9.2.0 * Update changelog for 9.2.0 (cherry picked from commit ea7acd6)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<changelog>Fix loading library failure by rollbacking to System.loadLibrary if SoLoader failed to load the library. </changelog>Resolves #367