Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Add SoLoader's proguard rule #71

Merged
merged 1 commit into from
Nov 27, 2019
Merged

Add SoLoader's proguard rule #71

merged 1 commit into from
Nov 27, 2019

Conversation

LukasPaczos
Copy link

Closes #60.

@LukasPaczos LukasPaczos added this to the release-tequila milestone Nov 27, 2019
@LukasPaczos LukasPaczos requested a review from a team November 27, 2019 11:15
@tobrun tobrun changed the title Add SoLoader's proaguard rule Add SoLoader's proguard rule Nov 27, 2019
tobrun
tobrun suggested changes Nov 27, 2019
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thinking about it, shouldn't this configuration live in the library loader module?

tobrun
tobrun approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@tobrun tobrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

different project 🤦‍♂️

@LukasPaczos LukasPaczos merged commit 561c2ed into master Nov 27, 2019
@LukasPaczos LukasPaczos deleted the lp-soloader-proguard branch November 27, 2019 11:45
@LukasPaczos
Copy link
Author

Changelog entry:

### Bugs
 - Fixed `VerifyError` thrown when proguard-optimized builds are run on a pre-Lollipop device by including `SoLoader`'s rules in the consumer proguard files. [#71](https://github.com/mapbox/mapbox-gl-native-android/pull/71)

@pengdev pengdev mentioned this pull request Dec 4, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tobrun tobrun tobrun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
release-tequila
Development

Successfully merging this pull request may close these issues.

A signed minifyEnabled release APK will cause VerifyError on Android 4.4
2 participants
@LukasPaczos @tobrun