This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Fix crash when quitting while a map view has annotations #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also removed unused method declarations.
If the underlying mbgl::Map has been torn down, so has the mbgl annotation, so don’t worry about the mbgl::Map but keep unregistering KVO and other SDK-side annotation resources.
|
@1ec5 let's cherrypick this into the 5.8.0 release? |
|
master and release-vanillashake have been even with each other this release cycle, so I’ve just been fast-forward-merging master into release-vanillashake without any cherry-picking. |
nishant-karajgikar
approved these changes
Apr 2, 2020
|
Thanks for this @1ec5 ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the underlying
mbgl::Maphas been torn down, so has the mbgl annotation, so don’t worry about thembgl::Map, but keep unregistering KVO and other SDK-side annotation resources.Also wrapped
MGLMapView’smbgl::Mapreference in astd::unique_ptrfor increased pointer safety.Fixes #87.
/cc @mapbox/maps-ios