Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Autodetect Xcode 12 to apply xcconfig patch #419

Merged
merged 3 commits into from
Sep 5, 2020
Merged

Autodetect Xcode 12 to apply xcconfig patch #419

merged 3 commits into from
Sep 5, 2020

Conversation

julianrex
Copy link
Contributor

This PR adds checks to the Makefile and the packaging script to check for an Xcode version matching "12.0", rather than relying on developers to append BETA=true to make commands or script incantations.

It also bumps the Xcode versions of the sanitize jobs to 11.7, fixes #351.

@julianrex julianrex requested review from a team and neelmistry94 and removed request for a team September 4, 2020 19:55
@julianrex julianrex self-assigned this Sep 4, 2020
@julianrex julianrex added the build label Sep 4, 2020
@julianrex julianrex merged commit 27596da into master Sep 5, 2020
@julianrex julianrex deleted the jrex/auto-detect-xcode12 branch September 5, 2020 13:35
katydecorah pushed a commit that referenced this pull request Sep 10, 2020
Merge branch 'master' into docs
70dd1da 
* master:
  Fix content insets when automaticallyAdjustsScrollViewInsets is set to NO (#420)
  Adds missing method for location test. (#422)
  Autodetect Xcode 12 to apply xcconfig patch (#419)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@neelmistry94 neelmistry94 neelmistry94 approved these changes

@fabian-guerra fabian-guerra Awaiting requested review from fabian-guerra

Assignees

@julianrex julianrex

Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update CircleCI sanitize and release jobs
2 participants
@julianrex @neelmistry94