Skip to content
This repository has been archived by the owner on Jun 21, 2023. It is now read-only.

Allow for transitive dependencies #431

Merged
merged 1 commit into from
Sep 14, 2020
Merged

Conversation

frederoni
Copy link
Contributor

Allow for transitive dependencies.

Currently when we are developing the next version of MME, the dependency tree cannot be resolved because MME in this SDK is pinned to a specific version.

[!] CocoaPods could not find compatible versions for pod "MapboxMobileEvents":
  In Podfile:
    Mapbox-iOS-SDK (~> 6.1.0) was resolved to 6.1.0, which depends on
      MapboxMobileEvents (= 0.10.2)

but I don't see any reason why we cannot allow for transitive dependencies so I'm adding the tadpole operator here.

cc @mapbox/maps-ios

@frederoni frederoni requested a review from a team September 14, 2020 11:56
@julianrex
Copy link
Contributor

julianrex commented Sep 14, 2020

This was related to mapbox/mapbox-events-ios#236, getting beta.1 out the door.

We're going to merge this, and make Xcode 11.1 / 11.3.1 builds not-required checks. However, we would like a quick fix for 236 😄

@fabian-guerra we should cherry pick for beta.2.

@julianrex julianrex merged commit c4944b6 into master Sep 14, 2020
@julianrex julianrex deleted the fred/allow-transitive-deps branch September 14, 2020 16:04
@julianrex julianrex mentioned this pull request Sep 14, 2020
6 tasks
@knov knov added this to the v6.2.0-beta.2 milestone Sep 14, 2020
katydecorah pushed a commit that referenced this pull request Sep 14, 2020
* master:
  Allow for transitive dependencies (#431)
  changing the default size for approx ring border when zoomed out (#429)
fabian-guerra pushed a commit that referenced this pull request Sep 14, 2020
@fabian-guerra fabian-guerra mentioned this pull request Sep 14, 2020
6 tasks
fabian-guerra added a commit that referenced this pull request Sep 14, 2020
* changing the default size for approx ring border when zoomed out (#429)

* Approximate Location "Puck" logic updates (#427)

* updates to approximate puck drawing logic

* removing unused header

* Allow for transitive dependencies (#431)

* Fix content insets when automaticallyAdjustsScrollViewInsets is set to NO (#420)

* Fix an issue when automaticallyAdjustContentInset is set to NO

* Update tests to account for safe areas on iOS 11

* Update changelog

* Update method documentation

* Update to gl-native 5.0.0 (#438)

* Update to application state management and associated view setup and rendering (#432)

Co-authored-by: Neel Mistry <Neel.mistry@mapbox.com>
Co-authored-by: Fredrik Karlsson <bjorn.fredrik.karlsson@gmail.com>
Co-authored-by: Julian Rex <julian.rex@mapbox.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants