This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[ios] Removed unused annotation image code
Removed unused annotation image code from iosapp, now that bulk-added point annotations are backed by annotation views.
- Loading branch information
Showing
1 changed file
with
0 additions
and
76 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
654f015
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I'd like to see come back here is a way to test annotation images in the test app for comparison. The reason we have 100, 1,000, and 10,000 annotations at all is to test it being very performant (#1076), so it would be good to have this as a basis for comparing the view-backed method and improvements to it in the future such as #5489.
@1ec5 @boundsj
654f015
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, we can bring back this code. Instead of MGLPointAnnotation, we’d subclass it and use that subclass to identify annotations we want to use MGLAnnotationImage for. We already do that for dropped pins, which still use the default GL-rendered image.
654f015
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, just wanted to see if there was any other context. I'll take a look at this.
654f015
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👉 #5786