Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Fix failing viewport-collision render tests #10412

Closed
ChrisLoer opened this issue Nov 8, 2017 · 4 comments
Closed

Fix failing viewport-collision render tests #10412

ChrisLoer opened this issue Nov 8, 2017 · 4 comments
Assignees
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl tests

Comments

@ChrisLoer
Copy link
Contributor

The following tests pass locally for me but give different results on some of our CI environments:

debug/collision-lines-pitched
debug/collision-lines
text-pitch-alignment/viewport-overzoomed-single-glyph
text-pitch-alignment/viewport-text-depthtest

/cc @ansis @jfirebaugh @kkaefer

@ChrisLoer ChrisLoer added the tests label Nov 8, 2017
@ChrisLoer ChrisLoer self-assigned this Nov 8, 2017
@ChrisLoer
Copy link
Contributor Author

text-pitch-alignment/viewport-overzoomed-single-glyph and text-pitch-alignment/viewport-text-depthtest are fixed.

I switched debug/collision-pitched-wrapped over to this issue. It was previously ignored against issue #3841, but it looks like theres an actual difference in collision result now, not just a difference in how collision boxes are rendered.

@anandthakker
Copy link
Contributor

Per @brunoabinader 's comment in mapbox/mapbox-gl-js#6250 (comment), I added ignores for real-world/{bangkok,chicago,sanfrancisco targeting this issue.

@stale
Copy link

stale bot commented Oct 27, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the archived Archived because of inactivity label Oct 27, 2018
@stale
Copy link

stale bot commented Dec 6, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Dec 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl tests
Projects
None yet
Development

No branches or pull requests

3 participants