-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added mvt-fixtures' real-world integration tests #6250
Conversation
45d4e6c
to
e94b9ab
Compare
Possible improvements include:
|
I've run these tests in GL native, and so far only tests that show road labels have failed - see e.g. Bangkok:
As pointed out by @ChrisLoer, there is a similar issue tracking label positioning diffs in mapbox/mapbox-gl-native#10412. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There are several existing tests that use local://../../node_modules/...
URLs. Please update these to use local://node_modules/...
as well.
e94b9ab
to
1f9305c
Compare
@jfirebaugh I ended up using Map's |
1d15db7
to
a87d1bc
Compare
a87d1bc
to
1d684a0
Compare
@brunoabinader just seeing this for the first time - awesome work! Lemme know if you have any issues with mvt-fixtures, happy to help with updates. |
Thanks @mapsam :) |
Adds real-world integration tests with data coming from https://github.com/mapbox/mvt-fixtures:
real-world/bangkok
real-world/chicago
real-world/nepal
real-world/norway
real-world/sanfrancisco
real-world/uruguay
Changes were made in the integration test HTTP server:
/node_modules
path mount (for finding .mvt files from the mvt-fixtures node module)local://
URLs also for sourcetiles
field (if used instead ofurl
)The tests' styles are all based in
basic-v9
, with slight changes:mapbox
sourcetiles
field is unique for each test (because the .mvt files are stored in separate folders)NotoCJK
because these provide the extra glyphsbasic-v9
style)