Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

'queryRenderedSymbols' results invalid between tile reload and next rendered frame #10778

Closed
ChrisLoer opened this issue Dec 21, 2017 · 1 comment
Closed

'queryRenderedSymbols' results invalid between tile reload and next rendered frame #10778

ChrisLoer opened this issue Dec 21, 2017 · 1 comment
Labels
bug release blocker Blocks the next final release

Comments

@ChrisLoer
Copy link
Contributor

ChrisLoer commented Dec 21, 2017 •
edited
Loading

Native equivalent of mapbox/mapbox-gl-js#5887

The window for invalid results lasts longer on native because placement may not happen for up to 300ms.

/cc @ansis @tobrun
@ChrisLoer ChrisLoer added the bug label Dec 21, 2017
@ChrisLoer ChrisLoer mentioned this issue Dec 21, 2017
Closed
@ChrisLoer ChrisLoer added the release blocker Blocks the next final release label Jan 10, 2018
This was referenced Jan 10, 2018
Closed
Merged
ChrisLoer added a commit that referenced this issue Jan 17, 2018
@ChrisLoer
[core] Synchronize state of CollisionIndex and FeatureIndexes.
7149c80 
Fixes issue #10778, in which mismatch between FeatureIndex and CollisionIndex could lead to inconsistent results or even invalid array access.
@ChrisLoer ChrisLoer mentioned this issue Jan 17, 2018
Merged
ChrisLoer added a commit that referenced this issue Jan 18, 2018
@ChrisLoer
[core] Synchronize state of CollisionIndex and FeatureIndexes.
656a637 
Fixes issue #10778, in which mismatch between FeatureIndex and CollisionIndex could lead to inconsistent results or even invalid array access.
@ChrisLoer
Copy link
Contributor Author

Fixed with #10950. The new behavior is that queryRenderedFeatures and querySourceFeatures continue returning old results until the next placement happens, at which point they move entirely to match the contents of the new CollisionIndex.

@ChrisLoer ChrisLoer mentioned this issue Jan 18, 2018
Closed
@julianrex julianrex mentioned this issue Jul 1, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug release blocker Blocks the next final release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisLoer