Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Streamline mbgl expression to NSExpression conversion #11254

Closed
1ec5 opened this issue Feb 20, 2018 · 1 comment
Closed

Streamline mbgl expression to NSExpression conversion #11254

1ec5 opened this issue Feb 20, 2018 · 1 comment
Assignees
@1ec5
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor release blocker Blocks the next final release
Milestone
ios-v4.0.0-boba

Comments

@1ec5
Copy link
Contributor

1ec5 commented Feb 20, 2018

Now that #11156 has landed, we can eviscerate MGLJSONObjectFromMBGLExpression() to make use of Expression::serialize() and MGLJSONObjectFromMBGLValue(). This should eliminate a number of roundtripping bugs between NSExpression and mbgl::style::expression::Expression.

/cc @ChrisLoer @nitaliano
@1ec5 1ec5 added iOS Mapbox Maps SDK for iOS refactor macOS Mapbox Maps SDK for macOS labels Feb 20, 2018
@1ec5 1ec5 added this to the ios-v4.0.0 milestone Feb 20, 2018
@1ec5 1ec5 self-assigned this Feb 20, 2018
@1ec5 1ec5 mentioned this issue Feb 20, 2018
Closed
@lilykaiser lilykaiser added the release blocker Blocks the next final release label Feb 20, 2018
@lucaswoj lucaswoj mentioned this issue Feb 26, 2018
Merged
10 tasks
This was referenced Feb 27, 2018
Merged
Merged
@1ec5
Copy link
Contributor Author

1ec5 commented Mar 30, 2018

Fixed in #11389 on the release-boba branch in time for iOS map SDK v4.0.0 and macOS map SDK v0.7.0.

@1ec5 1ec5 closed this as completed Mar 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@1ec5 1ec5

Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS refactor release blocker Blocks the next final release
Projects
None yet
Milestone
ios-v4.0.0-boba
Development

No branches or pull requests
2 participants
@1ec5 @lilykaiser