This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Cherry-pick Expression.serialize() #11312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The native ignore for #6160 (562abdd) probably shouldn't be cherry picked because that fix has gone in on the native side (although @ansis it looks to me like maybe that didn't make it into boba yet and probably should) @brunoabinader is working on the build failure at #11316 |
|
To get the build working, rebase this on top of |
|
10 tasks
Issue #10714 - Each expression stores its operator as a string, and default serialization is [operator, serialize(child1), ...] - Custom implementations of `serialize` for Expression types that don't follow the pattern - expression::Value -> mbgl::Value converter - node_expression bindings to expose `serialize`
- Round-tripping expressions through serialization and checking that outputs don't change - Checking expression serialization against expected value from fixture
jfirebaugh
force-pushed
the
tvn-cp-serialize
branch
from
562abdd
to
c7c5602
Compare
jfirebaugh
approved these changes
Mar 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of Expression.serialize() from #11156. This is needed for accessor support on Android for #10721. I recall iOS moving to the same approach (can't find the comment atm).
cc @ChrisLoer @1ec5