Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios, macos] remove references to [MGLOfflineStorage sharedOfflineStorage] from internal methods. #13877

Closed
julianrex opened this issue Feb 5, 2019 · 3 comments
Labels
archived Archived because of inactivity iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline tests

Comments

@julianrex
Copy link
Contributor

iOS/macOS versions: 4.7.0

We should consider removing the explicit dependency on [MGLOfflineStorage sharedOfflineStorage] from MGLOfflinePack, MGLMapSnapshotter and MGLRendererConfiguration.

This would pave the way to support multiple offline storage objects which would be especially useful during (parallel) testing.

@julianrex julianrex added iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS labels Feb 5, 2019
@1ec5
Copy link
Contributor

1ec5 commented Feb 12, 2019

These classes refer to the shared object via the class method to avoid maintaining a backreference to the file source. Most of the actual offline pack functionality lives in MGLOfflineStorage rather than MGLOfflinePack. This architecture is somewhat dictated by mbgl::OfflineManager, which isn’t quite as object-oriented as what we expose publicly on iOS and macOS. All three classes depend on the file source, which exists in mbgl as a singleton.

@stale stale bot added the archived Archived because of inactivity label Aug 11, 2019
@stale
Copy link

stale bot commented Aug 11, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Aug 11, 2019
@julianrex julianrex reopened this Sep 10, 2019
@stale stale bot removed the archived Archived because of inactivity label Sep 10, 2019
@stale stale bot added the archived Archived because of inactivity label Mar 8, 2020
@stale
Copy link

stale bot commented Mar 8, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Mar 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline tests
Projects
None yet
Development

No branches or pull requests

2 participants