Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[ios] Refactor MGLOfflineStorage #15598

Closed
julianrex opened this issue Sep 10, 2019 · 2 comments
Closed

[ios] Refactor MGLOfflineStorage #15598

julianrex opened this issue Sep 10, 2019 · 2 comments
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline refactor
Milestone

Comments

@julianrex
Copy link
Contributor

julianrex commented Sep 10, 2019

In the context of working on #15536, it's become apparent that we should consider refactoring MGLOfflineStorage to include:

  1. Improve testing by allocating a test specific MGLOfflineStorage, and not relying on sharedOfflineStorage: [ios, macos] remove references to [MGLOfflineStorage sharedOfflineStorage] from internal methods. #13877
  2. Support accessing from a background thread: OfflineMapManager is crashing on serial queue access #15536 & [iOS] Offline download from background thread #14206
  3. Improve progress notifications: MGLOfflineStorage addContentsOfURL with progress #14877
  4. Support background downloads: Support background transfers on iOS #4291
@julianrex julianrex added iOS Mapbox Maps SDK for iOS refactor macOS Mapbox Maps SDK for macOS labels Sep 10, 2019
@julianrex julianrex added this to the ios-future milestone Sep 10, 2019
@1ec5
Copy link
Contributor

1ec5 commented Sep 12, 2019

Support background downloads: #4291

Background downloads will require some significant refactoring in mbgl, not just the SDK code, because background download tasks break several of mbgl’s assumptions around offline downloads.

@julianrex
Copy link
Contributor Author

Closing as won't-fix/stale. cc @knov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
iOS Mapbox Maps SDK for iOS macOS Mapbox Maps SDK for macOS offline refactor
Projects
None yet
Development

No branches or pull requests

3 participants