Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

pod broken in 0.37.0 (proper fix) #1426

Closed
incanus opened this issue May 5, 2015 · 10 comments
Closed

pod broken in 0.37.0 (proper fix) #1426

incanus opened this issue May 5, 2015 · 10 comments
Assignees
Labels
bug build iOS Mapbox Maps SDK for iOS
Milestone

Comments

@incanus
Copy link
Contributor

incanus commented May 5, 2015

I think this is the upstream issue: CocoaPods/CocoaPods#3106

Per the changelog:

Do not create pod target if source_files only contains headers.

m.source_files = 'Headers/*.h'

Things work fine right now with 0.36.4, so do this:

  • gem uninstall cocoapods cocoapods-core
  • gem install cocoapods -v 0.36.4
  • rm -rf Podfile.lock Pods
  • pod install
@incanus
Copy link
Contributor Author

incanus commented May 5, 2015

Yeah, this is flat-out a bug in CocoaPods 0.37.0. Hopefully it'll get fixed in time for our launch 😬

@neonichu
Copy link

neonichu commented May 6, 2015

Worst case you should be able to work around it by adding a dummy/empty .m file to your source_files.

@incanus
Copy link
Contributor Author

incanus commented May 6, 2015

Ah, I had thought about that — thanks for the tip.

@incanus
Copy link
Contributor Author

incanus commented May 6, 2015

Managed to fix this using @neonichu's workaround above. Once tests pass, I will merge this and move this ticket to b2 milestone since non-critical.

@geografa @katydecorah @mapbox/mobile CocoaPods 0.37.0 will work again once this lands.

  • gem uninstall -a cocoapods cocoapods-core
  • gem install cocoapods -v 0.37.0
  • rm -rf Podfile.lock Pods
  • pod install

@incanus
Copy link
Contributor Author

incanus commented May 6, 2015

Travis acting up — tests locally.

incanus added a commit that referenced this issue May 6, 2015
refs #1426: add dummy source file to workaround CocoaPods 0.37.0 bug
@incanus
Copy link
Contributor Author

incanus commented May 6, 2015

In master as of 6c31d92. Moving eventual proper resolution to b2.

@incanus incanus modified the milestones: iOS Beta 2, iOS Beta 1 May 6, 2015
@incanus
Copy link
Contributor Author

incanus commented Jun 1, 2015

Not critical for b2; pushing for now.

@incanus incanus modified the milestones: iOS Beta 3, iOS Beta 2 Jun 1, 2015
@1ec5 1ec5 changed the title pod broken in 0.37.0 pod broken in 0.37.0 (proper fix) Jun 1, 2015
@incanus incanus modified the milestone: iOS Beta 3 Jul 7, 2015
@incanus
Copy link
Contributor Author

incanus commented Nov 9, 2015

Obsoleted by #2132; we should clean up here.

@incanus
Copy link
Contributor Author

incanus commented Nov 9, 2015

cf.

step "Setting up dummy source file for CocoaPods 0.37.0..."
echo "// https://github.com/mapbox/mapbox-gl-native/issues/1426" > "${OUTPUT}/static/MGLDummy.m"

friedbunny added a commit that referenced this issue Nov 17, 2015
- Remove MGLDummy.h (#1426)
- Remove `-ObjC` linker flag (#2966)
@incanus incanus added this to the ios-v3.1.0 milestone Nov 23, 2015
@1ec5
Copy link
Contributor

1ec5 commented Dec 7, 2015

This will be moot once we move to a dynamic framework in #3182 and/or #3183.

@incanus incanus closed this as completed in 032e3a6 Dec 7, 2015
@incanus incanus removed the ready label Dec 7, 2015
incanus added a commit that referenced this issue Dec 7, 2015
- Add license file to framework build step to satisfy CocoaPods linting.
- Log version when rolling framework (refs #3046).
- fixes #1426: get rid of dummy file since we make our own framework.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug build iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests

4 participants