Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

When it will support 3D model? #14494

Open
nicolae1992 opened this issue Apr 24, 2019 · 38 comments
Open

When it will support 3D model? #14494

nicolae1992 opened this issue Apr 24, 2019 · 38 comments
Labels
Android Mapbox Maps SDK for Android iOS Mapbox Maps SDK for iOS

Comments

@nicolae1992
Copy link

nicolae1992 commented Apr 24, 2019

When it will support 3D GLTF or other formats in mapbox android sdk

Android versions:
Device models:
Mapbox SDK versions:

@tobrun tobrun added the Android Mapbox Maps SDK for Android label Apr 29, 2019
@tobrun
Copy link
Member

tobrun commented Apr 29, 2019

This is something we are thinking about exposing an API around though atm can't give you a concrete eta. The formats are still TBD but ideally it would be an open format. We will follow up with more concrete issues in the near future, closing this issue as answered for now.

@tobrun tobrun closed this as completed Apr 29, 2019
@noway
Copy link

noway commented Jun 27, 2019

@tobrun Is there anywhere where we can vote to prioritise that feature? We are using mapbox and will need 3d map annotations very soon.

Both Android and iOS version.

@julianrex julianrex added the iOS Mapbox Maps SDK for iOS label Jun 28, 2019
@nicolae1992
Copy link
Author

@noway Thx, This task is very important

@astojilj
Copy link
Contributor

@noway @nicolae1992

mapbox-gl-js demo https://bl.ocks.org/ryanbaumann/b9725e79b5b1742d92ada00ddbf5c3d3 uses Three.js for loading GLTF model. We don't plan to include GLTF model loader to mapbox code - hopefully you were able to find a loader to use. Please notify if following similar approach (custom layer e.g. mapbox/mapbox-gl-js#7977 and https://bl.ocks.org/ryanbaumann/b9725e79b5b1742d92ada00ddbf5c3d3) doesn't work for you.

@nicolae1992
Copy link
Author

@astojilj this link is js, but needed for Android SDK

@astojilj
Copy link
Contributor

@astojilj this link is js, but needed for Android SDK

Yes, mapbox-gl-js demo is useful to explain the approach: similarly, you'd need to load GLTF model using loader of your choice and use custom layer approach, as mentioned in #14494 (comment)

@noway
Copy link

noway commented Aug 27, 2019

@astojilj I'm using mapbox for react native, so ideally I need the 3d model layer support in react-native-mapbox-gl/maps package. I assume it would be something along the lined of

<MapboxGL.MapView>
  <MapboxGL.ThreeDLayer shape={shape} meshes={meshes}>
  </MapboxGL.ThreeDLayer>
</MapboxGL.MapView>

or something similar. I don't think I have capacity to build that feature out for react-native-mapbox-gl/maps package by my own. I heard that you guys are not supporting this package, so it might be on @nitaliano to port this to RN world. A fully figured out and documented Android/iOS support though is a good first step. I'm not sure if your mapbox-gl-js example would work for mapbox-sdk-ios/mapbox-sdk-android as it is?

@luckkyzhou
Copy link

@astojilj this link is js, but needed for Android SDK

Yes, mapbox-gl-js demo is useful to explain the approach: similarly, you'd need to load GLTF model using loader of your choice and use custom layer approach, as mentioned in #14494 (comment)

Hi, I have found a java loader to load GLTF model. But now I need the documentation of custom layer approach for android SDK. I couldn't find how to custom layer with android, so is there any documentation about this?

@NickLambert95
Copy link

@tobrun Has there been an update on 3D objects in android yet? We're trying to put 3D cars on our map and have successfuly achieved it through the web gl but not on android or iOS

@noway
Copy link

noway commented Apr 25, 2020

Can this be reopened?

@tobrun
Copy link
Member

tobrun commented Apr 28, 2020

cc @chloekraw

@tobrun tobrun reopened this Apr 28, 2020
@chloekraw
Copy link
Contributor

Hi folks, thanks for all your interest in this feature. Support for 3D objects is something we are exploring; there's no timeline for its release. We'll keep you posted.

@NickLambert95
Copy link

Hi folks, thanks for all your interest in this feature. Support for 3D objects is something we are exploring; there's no timeline for its release. We'll keep you posted.

Hey @chloekraw not to be rude but this is the exact same answer we've heard over a year ago. Is there any updates on this? There are a lot of benefits and uses this feature can bring and we really need this for our app. Are there any work arounds that may accomplish this?

Thanks

@leedejun
Copy link

leedejun commented Jul 28, 2020

@chloekraw @nicolae1992 @NickLambert95

I have finished loading 3d model with mapbox gl native, implement a custom layer that loads the 3D model, referencing the assimp library.

@NickLambert95 You could check out my comment:

#13157 (comment)

@NickLambert95
Copy link

@chloekraw @nicolae1992 @NickLambert95

I have finished loading 3d model with mapbox gl native, implement a custom layer that loads the 3D model, referencing the assimp library.

@NickLambert95 You could check out my comment:

#13157 (comment)

Hey @leedejun how exactly did you do this? Can I see your code that you edited? Thanks

@janweigel
Copy link

Hi @leedejun,
Could you please share the code you wrote to achieve 3D object layers for iOS and Android?
We need the same feature and there's no update for any official support for more than a year.
Any help appreciated.
Thank you!

@NickLambert95
Copy link

@janweigel He never got back to me either but it appears he made this in React Native (which is the web version of mapbox)

@patrickkempff
Copy link

@janweigel He never got back to me either but it appears he made this in React Native (which is the web version of mapbox)

React Native does not use the web version of mapbox afaik

@NickLambert95
Copy link

@patrickkempff Maybe not react native then. The mapbox GL version (which works on web) allows you to add GLTF files as 3D models. There isn't a workaround I'm aware of for iOS and Android

@janweigel
Copy link

If I get the post of @leedejun correctly then he modified the c++ code to add that feature to the native android and ios version and not the gl js version of mapbox.
That's exactly what I'm looking for.

@NickLambert95
Copy link

@janweigel Yeah I desperately need that function too. Let me know if he ever gets back to you and I'll do the same for you

@leedejun
Copy link

leedejun commented Sep 24, 2020

Hi, @patrickkempff @NickLambert95 @janweigel

I understand your problem, I solved it.
I achieved it by modifying the custom layer of mapbox gl native in Mac, linux, android, windows,
and used the Assimp library.

But I can't share my code, I wish share my code after I leave the current company.
I would like share my method with you.
the method detail:

  1. The Assimp is able to read the model files;
  2. Add a function for Convert latitude and longitude to Opengl coordinates, Rang: [-1.0,1.0] ;
  3. Implement mapbox custom layer to draw 3d model.

@janweigel
Copy link

janweigel commented Sep 25, 2020

Hi @leedejun,
Thanks for sharing that info.
I'll see if I can implement the native part for a custom layer myself.

It would be even better if this would be part of the official mapbox native code.

@Amrutha1991
Copy link

Hi @janweigel @leedejun
Thanks for the information.
It would be helpful if anyone share the snippet for, custom layer to draw 3d model using mapbox native code.

Thanks in advance

@fabdrol
Copy link

fabdrol commented Nov 23, 2020

It'd be even more useful if the code was shared with Mapbox, so @chloekraw can implement this officially

@NickLambert95
Copy link

Anyone have an update on this topic? Any solutions? @janweigel @fabdrol @patrickkempff @tobrun @luckkyzhou @leedejun @chloekraw

@Cal-um
Copy link

Cal-um commented Dec 8, 2020

Also requesting 3D model support on iOS and Android.

@janweigel
Copy link

@NickLambert95 and @Cal-um
We switched to Unity using the Mapbox Unity SDK, as it wasn't possible to wait for those features.

@NickLambert95
Copy link

@janweigel Oh I see. Out of curiosity does Mapbox Unity come with the same navigation features? As in, could I build a full fledge app with the navigation SDK and directions API in it? I looked this up before but couldn't find any information as to whether Unity supported it

@Cal-um
Copy link

Cal-um commented Dec 9, 2020

that's a good shout. Probably better for my use case as well. Just need to learn unity 😂

@ajbraudev
Copy link

We are in desperate need of this as well. Hoping to hear an update soon.

@JeyBi24
Copy link

JeyBi24 commented Jan 28, 2021

YES PLEASE, ADD 3D OBJECTS support for ANDROID and IOS

@astojilj
Copy link
Contributor

astojilj commented Mar 4, 2021

iOS example using SceneKit: mapbox/mapbox-maps-ios#154

@NickLambert95
Copy link

NickLambert95 commented Jun 14, 2021

@tobrun @chloekraw you posted this comment, but I can no longer find it. I'm not seeing the support for 3D models on the links you sent

"Sorry for the long delay on this, we have been hard at work and do appreciate you all reaching out and requesting this feature. Not sure if you noticed but we announced the v10.0.0-beta last week. This release of the SDK, which has been rewritten from the ground up, adds support for 3D terrain and 3D model.

The repositories for these libraries are:

https://github.com/mapbox/mapbox-maps-android
https://github.com/mapbox/mapbox-maps-ios
While it's still in beta, not production ready yet, we do invite you to try it out and provide feedback."

@ajbraudev
Copy link

@tobrun Any update on this? We would be willing to contribute and collaborate on this issue if necessary. Would love to hear an update, even if it's bad news. Thanks Mapbox Team!

@soheilnikbin
Copy link

Hi @astojilj , it seems that the Mapbox iOS SDK 3D Puck is using the private ModelLayer to render glTF objects. We are wondering why this functionality is not publicly available, as it would simplify our development. It seems there is a demand for this feature.

@b4rtt
Copy link

b4rtt commented Jan 21, 2023

Hi @astojilj , it seems that the Mapbox iOS SDK 3D Puck is using the private ModelLayer to render glTF objects. We are wondering why this functionality is not publicly available, as it would simplify our development. It seems there is a demand for this feature.

Yes. 👍🏻

@astojilj
Copy link
Contributor

astojilj commented Feb 2, 2023

Hello,
We are working on this, as presented in https://www.mapbox.com/blog/mapbox-3d-navigation.

image

I cannot share implementation details or milestones now. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Android Mapbox Maps SDK for Android iOS Mapbox Maps SDK for iOS
Projects
None yet
Development

No branches or pull requests