Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

[core] fill-extrusion-vertical-gradient always rendered as false #14784

Closed
astojilj opened this issue May 28, 2019 · 0 comments · Fixed by #14808
Closed

[core] fill-extrusion-vertical-gradient always rendered as false #14784

astojilj opened this issue May 28, 2019 · 0 comments · Fixed by #14808
Assignees
@astojilj
Labels
bug Core The cross-platform C++ core, aka mbgl rendering
Milestone
release-picklejuice

Comments

@astojilj
Copy link
Contributor

Render test output show the tests passing:

  • passed fill-extrusion-vertical-gradient/default
  • passed fill-extrusion-vertical-gradient/false

Left side is the actual and expected for default and right side is for false.

Screenshot 2019-05-28 at 17 32 12

Apparently, it always renders as if false is set.
Tolerance is too high and it went unnoticeable by render tests.
Works as expected in mapbox-gl-js - default is true.

Related to PR #13462,mapbox/mapbox-gl-js#5768
@astojilj astojilj self-assigned this May 28, 2019
astojilj added a commit that referenced this issue May 30, 2019
@astojilj
[core] Fix: fill-extrusion-vertical-gradient was ignored. #14784
e3d8448 
fill-extrusion-vertical-gradient "property-type": "data-constant" and it shouldn't be computed through property binders.

Fixes: #14784
@astojilj astojilj mentioned this issue May 31, 2019
Merged
astojilj added a commit to mapbox/mapbox-gl-js that referenced this issue May 31, 2019
@astojilj
Tweak tolerance in render tests to expose false passing test
059e375 
fill-extrusion-vertical-gradient/default was [falsely passing - Issue #14784](mapbox/mapbox-gl-native#14784).
This tweak makes the test fail while keeping other tests passing.
@astojilj astojilj mentioned this issue May 31, 2019
Merged
mourner pushed a commit to mapbox/mapbox-gl-js that referenced this issue May 31, 2019
@astojilj @mourner
Tweak tolerance in render tests to expose false passing test (#8309)
f7d1466 
fill-extrusion-vertical-gradient/default was [falsely passing - Issue #14784](mapbox/mapbox-gl-native#14784).
This tweak makes the test fail while keeping other tests passing.
astojilj added a commit that referenced this issue May 31, 2019
@astojilj
[core] Fix: fill-extrusion-vertical-gradient was ignored. #14784
62f6338 
fill-extrusion-vertical-gradient "property-type": "data-constant" and it shouldn't be computed through property binders.

Fixes: #14784
@iBinh iBinh mentioned this issue Jun 17, 2019
Closed
@friedbunny friedbunny added bug Core The cross-platform C++ core, aka mbgl rendering labels Jun 19, 2019
@friedbunny friedbunny added this to the release-p milestone Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@astojilj astojilj

Labels
bug Core The cross-platform C++ core, aka mbgl rendering
Projects
None yet
Milestone
release-picklejuice
Development

Successfully merging a pull request may close this issue.

[core] Fix: fill-extrusion-vertical-gradient was ignored. #14784 mapbox/mapbox-gl-native
2 participants
@astojilj @friedbunny