-
Notifications
You must be signed in to change notification settings - Fork 1.3k
incremental parsing #163
Comments
This would be great. It probably makes sense to do this bottom-to-top if that's not already the natural order in order to look best, but that could be a second refinement. |
How likely do you think this is to happen for WWDC @kkaefer? |
Not likely. Incremental parsing means that we have to think hard about how the buffers are organized; right now, we're e.g. using one elements buffer that is shared across all buckets and bucket types. That means that if we parse a fill, but have previously parsed all lines (and are attempting to render the line), we are going to modify the elements buffer again, and have to handle updates (e.g. using |
This also really complicates clipping. Each layer would have a different set of tiles to render from. Separating just text and non-text buckets is probably more realistic |
@ansis not sure I follow. This ticket is about incremental parsing. Why would that affect clipping? |
If the incrementally parsed tiles replace previously loaded tiles, then as each layer from the new tile is parsed and displayed the same layer from the old tile has to be clipped. Different layers from the old overscaled tile may be clipped differently. Supporting different clippings for different layers is the same problem as supporting clipping for multiple sources #220. I don't think its possible to support overscaling this many different clippings with the current clipping approach. Just 8 stencil bits and testing with a mask and equal isn't enough without redrawing the stencil multiple times. It would be awesome if I was wrong about this though |
#1326 has the interesting side effect of making this possible (it will be my next step as soon as I get rid of the promises). |
No current plans to pursue this. |
We should create the buckets for a tile incrementally, filling them/adding them as we go. This makes the app feel a little faster because you at least see something, e.g. you see all the streets, but not labels yet.
refs #158
The text was updated successfully, but these errors were encountered: