Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

non-solid matte #119

Open
incanus opened this issue Mar 26, 2014 · 24 comments
Open

non-solid matte #119

incanus opened this issue Mar 26, 2014 · 24 comments
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl feature MapKit parity For feature parity with MapKit on iOS or macOS

Comments

@incanus
Copy link
Contributor

incanus commented Mar 26, 2014

We should consider a non-solid matte for better context. Consider Apple Maps's grid:

https://dl.dropboxusercontent.com/u/575564/matte.mov

matte

@kkaefer
Copy link
Contributor

kkaefer commented Mar 26, 2014

Yes

@incanus
Copy link
Contributor Author

incanus commented May 26, 2014

@kkaefer how tough is this to hit? Should this be manually drawn somehow or just have a texture used repetitively?

@incanus
Copy link
Contributor Author

incanus commented May 30, 2014

Bump on this. @kkaefer is this difficult? I'm hesitant to just put a texture in there for performance reasons, so I don't know best approach here. But with a blank map, stalls give the appearance of no interaction, when really panning, zooming, and rotating are still working.

@ajashton
Copy link
Member

:/

If we must can it be suuuper subtle? The apple grid is gross.

@incanus
Copy link
Contributor Author

incanus commented May 30, 2014

Yeah, we can make it very light. We can double back on this later. I think it's important for a demo, though.

@ansis
Copy link
Contributor

ansis commented May 30, 2014

-js preloads a couple tiles at much lower zoom levels that get overscaled a ton to fill gaps when panning and zooming. I'm not sure if they provide helpful context, or if overscaling looks terrible.
pantile

@incanus
Copy link
Contributor Author

incanus commented Jun 2, 2014

I think I mostly have this working if I can just get an image into the sprite. @edenh @nickidlugash what process are we using to add assets to the sprite currently?

@incanus
Copy link
Contributor Author

incanus commented Jun 2, 2014

This is working pretty well in this branch with a correct sprite image. We'll work on a more refined version with major/minor gridlines next.

@incanus
Copy link
Contributor Author

incanus commented Jun 2, 2014

Done in #301.

@incanus incanus closed this as completed Jun 2, 2014
@incanus
Copy link
Contributor Author

incanus commented Jun 3, 2014

We took this back out in 7a4a833 for performance reasons, so this still needs to happen.

@incanus incanus reopened this Jun 3, 2014
@jfirebaugh jfirebaugh removed this from the WWDC milestone Aug 28, 2014
@jfirebaugh
Copy link
Contributor

Can't this be done in the style via background-image when it's desired?

@incanus
Copy link
Contributor Author

incanus commented Aug 29, 2014

The idea is that the grid represents the "surface" that the map is drawn on, which orients gestural interaction better, before any actual content is drawn. As such, as long as it has zero delay relating to style parsing, tile download/parse/render, and the like, it could work. I think we would need #163 first though, or else background-image would be dependent on the start of initial render for a tile.

@incanus incanus added this to the iOS Beta milestone Feb 13, 2015
@incanus incanus removed this from the iOS Beta milestone Mar 3, 2015
mikemorris added a commit that referenced this issue Aug 21, 2015
@1ec5 1ec5 added the MapKit parity For feature parity with MapKit on iOS or macOS label Aug 22, 2016
@soupman99
Copy link

+1

@kkaefer kkaefer added the Core The cross-platform C++ core, aka mbgl label May 29, 2017
@stale stale bot added the archived Archived because of inactivity label Nov 7, 2018
@stale
Copy link

stale bot commented Nov 28, 2018

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 28, 2018
@riastrad
Copy link
Contributor

riastrad commented Feb 4, 2019

Sorry @stale, but this is still a sometimes requested feature - so I think it's worth revisiting whether or not this would be possible to include. Especially now that some time has passed since the original grid was reverted.

@riastrad riastrad reopened this Feb 4, 2019
@stale stale bot removed archived Archived because of inactivity labels Feb 4, 2019
@ulusoyca
Copy link

ulusoyca commented Feb 14, 2019

This issue was referenced in #11814
I agree with @riastrad that we need this feature especially for my case where I need to distinguish background layer and unloaded tile visually

@tobrun
Copy link
Member

tobrun commented Apr 26, 2019

GL-native supports the same UX as GL-JS shown in #119 (comment). This is a better UX as showing a grid or nothing at all. @ulusoyca could you elaborate why this is needed for your use-case?

@ulusoyca
Copy link

@tobrun Correct me if I am wrong but the comment you pointed assumes that there are preloaded tiles. In my use case, there is no guarantee of preloaded tiles so it makes difficult to distinguish unloaded tile from background layer

@tobrun
Copy link
Member

tobrun commented Apr 26, 2019

that is correct, you will just see the background color. One way to achieve your effect, haven't verified this but should work, would be to updating your style with:

  • adding a fill layer above background layer with current background color and linking a geometry spanning the world.
  • updating background layer to use background-pattern with something as a grid shown in OP

@ulusoyca
Copy link

@tobrun

adding a fill layer above background layer with current background color and linking a geometry spanning the world.

  1. Any instructions on how I can link a geometry spanning the world?
  2. Should I add the fill layer programmatically? Is it doable in mapbox studio?

@ulusoyca
Copy link

Ok, I was able to add the layer through Mapbox Studio with the following dataset:

  "geometry": {
    "coordinates": [
      [
        [-180, -90],
        [180, -90],
        [180, 90],
        [-180, 90],
        [-180, -90]
      ]
    ],
    "type": "Polygon"
  },
  "type": "Feature",
  "properties": {
    "name": "full_world_cover"
  }

@stale stale bot added the archived Archived because of inactivity label Nov 18, 2019
@stale
Copy link

stale bot commented Nov 18, 2019

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed Nov 18, 2019
@riastrad riastrad reopened this Nov 18, 2019
@stale stale bot removed the archived Archived because of inactivity label Nov 18, 2019
@stale stale bot added the archived Archived because of inactivity label May 16, 2020
@stale
Copy link

stale bot commented May 16, 2020

This issue has been automatically detected as stale because it has not had recent activity and will be archived. Thank you for your contributions.

@stale stale bot closed this as completed May 16, 2020
@alexshalamov alexshalamov reopened this May 18, 2020
@stale stale bot removed the archived Archived because of inactivity label May 18, 2020
@stale stale bot added the archived Archived because of inactivity label Nov 15, 2020
acalcutt pushed a commit to acalcutt/mapbox-gl-native that referenced this issue Apr 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived Archived because of inactivity Core The cross-platform C++ core, aka mbgl feature MapKit parity For feature parity with MapKit on iOS or macOS
Projects
None yet
Development

No branches or pull requests